[WIP] Broker CR reconciler#1638
Draft
hidalgopl wants to merge 7 commits into
Draft
Conversation
Flesh out the Broker controller to manage pod lifecycle (create, adopt, shadow), PVC provisioning, status conditions, and broker ID resolution via the admin API. Pod-mutating actions are gated by the operator.redpanda.com/roll-grant annotation whose config-checksum must match the desired pod template checksum, keeping the Broker controller a dumb executor while the cluster controller serialises rolls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Implement executeDecommission in the Broker reconciler: check DecommissionBrokerStatus, initiate if not yet started, block on last broker (RFC Q2). Add broker-crd.feature acceptance test covering the full lifecycle: pod adoption from orphan-deleted StatefulSet, roll-grant gating, broker ID resolution, and decommission to completion. Temporarily flip --enable-broker and --experimental defaults to true for testing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…roller Detect checksum drift between desired pod template and running pod. When a valid roll-grant is held and checksums diverge, enable maintenance mode on the broker via admin API, then delete the pod so the next reconcile recreates it from the updated spec. Adoption now stamps the checksum annotation on the pod to prevent a spurious delete+recreate cycle. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hidalgopl
requested review from
RafalKorepta,
andrewstucki,
chrisseto and
gene-redpanda
as code owners
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…d finalizer, PV remediation, drain Restructure BrokerReconciler.Reconcile into a state struct + ordered sub-reconciler chain matching the RedpandaReconciler style. Add: - brokerReconciliationState / brokerReconcilerFn types - Finalizer with decommission-on-delete and rollback-safe removal - PV node-affinity remediation via pvcunbinder.DeadNodePVCs - Maintenance mode drain before pod rotation (ensureDrained) - Post-decommission pod + PVC cleanup - Broker ID continuity check and maintenance mode disable - Extended status conditions (PodScheduled, BrokerRegistered, ConfigOutdated, StorageBound) - Roll-grant deadline validation - Integration test suite and acceptance test steps Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hidalgopl
force-pushed
the
pb/broker-cr-reconciler
branch
from
30834f8 to
44b9c13
Compare
…n test Pre-fetch pod in Reconcile via fetchState instead of inline construction, making state.pod nil when the pod doesn't exist. Guard reconcilePod and reconcilePVCs against recreating resources for decommissioned brokers. Fix TestPVAffinityRemediation to use VolumeClaimTemplates so the controller can recreate PVCs after remediation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hidalgopl
force-pushed
the
pb/broker-cr-reconciler
branch
from
44b9c13 to
3137fda
Compare
The Broker controller was defaulting to enabled, but the Broker CRD isn't in the kustomize overlay that kuttl uses — crashing the operator on startup and failing all V1 nodepool kuttl tests. Default to false and explicitly opt in via acceptance test flags. Also extract shared test setup into setupBrokerCluster helper, inline newMulticlusterPod (only 2 call sites), and drop unused Gherkin step parameter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…de cleanup Add SkipNameValidation to NodePool, Redpanda, and Broker controllers so multiple test suites can register same-named controllers in one process without hitting controller-runtime's global metrics name check. Add t.Cleanup in TestPVAffinityRemediation to restore a deleted k3d node if the test fails before the in-test replacement, preventing cascading failures in other tests sharing the k3d cluster. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.